pastelsky/bundlephobia

Getting 404 for empty input

Open

#770 创建于 2023年4月4日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (8,477 star) (250 fork)batch import
buggood first issue

描述

Describe the bug It looks like it is expected behaviour but I don't think we should allow an empty input call from the frontend.

To Reproduce Don't type anything in the search box and press enter. It takes you to https://bundlephobia.com/package which gives 404.

Expected behavior I believe we should just do nothing when the input is empty.

Let me know if the suggested fix is good and I can make a relevant PR for the same.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
needs maintainer response
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic javascriptbasic react
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95
研究方向
Examine the search input component (likely in SearchBar.js) to find the form submission handler. Add a conditional check to prevent navigation or API call when the input is empty. Refer to the expected behavior described in the issue.