papercups-io/papercups

Better phone number filtering for twillio and SMS in integrations page

Open

#816 创建于 2021年5月5日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)Elixir (6,032 star) (566 fork)batch import
enhancementgood first issue

描述

Problem Right now if you enter a phone number without the area code or have the wrong formatting in phone number section it will fail silently and not work. We should make sure that there is a country code and that it can work regardless of the text formatting

Solution It should validate that it has a country code and we shouldn't care about formatting

贡献者指南

技术栈
elixir
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Elixir basicsphone number validation concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the current phone number input handling in the integrations page, likely in a Phoenix template or LiveView. Look for validation logic in lib/ or web/ directories. Consider using a library like ex phone number or implementing a simple regex for country code presence. Check comments for any existing discussions on preferred approach. The issue specifies ignoring formatting, so focus on stripping non digit characters and ensuring a length that implies a country code (e.g., >= 10 digits).