panzarino/mlbgame

Stop converting HTTPError to ValueError in mlbgame/data.py

Open

#92 创建于 2018年4月27日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)Python (509 star) (116 fork)batch import
enhancementhelp wantedquestion

描述

Converting HTTPError to ValueError loses valuable information about the failure. If the HTTPError itself was allowed to be raised then callers could look at the status code and determine if they want to try the call again (in the case of a 5xx error) or stop trying (4xx error).

Or maybe it could raise new exceptions defined by the mlbgame library? Fatal or Retryable?

贡献者指南

技术栈
python
领域
backendapi
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
understanding of Python exception handlingbasic knowledge of HTTP status codes
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Look at `mlbgame/data.py` where `HTTPError` is caught and converted to `ValueError`. The issue suggests either letting the original `HTTPError` propagate or defining custom exceptions like `Fatal` or `Retryable`. Check the existing exception hierarchy in the codebase and decide which approach aligns with the library's design. Also review any comments in the issue for further discussion.
Stop converting HTTPError to ValueError in mlbgame/data.py · panzarino/mlbgame#92 | Good First Issue