palantir/blueprint

Toaster with timeout zero is dismissed early

Open

#6,742 创建于 2024年3月14日

在 GitHub 查看
 (6 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): "@blueprintjs/core": "^5.10.0",
  • Operating System: Mac OS 14
  • Browser name and version: Chrome 122

Code Sandbox

Code sandbox

Steps to reproduce

See the linked code sandbox

  1. Open a Toast with timeout of 0. Note that focusing the toast will dismiss it (without clicking the 'x')
  2. Note that with an explicit timeout (e.g. 100_000) this is not the case; Toast remains open after focusing.
  3. timeout: Infinity is poorly behaved; Toast immediately closes

Actual behavior

See above and also screen recording from sandbox:

https://github.com/palantir/blueprint/assets/20345725/40bc7800-1b37-4cf9-bd1a-405425e835df

Expected behavior

Toast with timeout: 0 should not dismiss early. timeout: Infinity should also behave the same as timeout: 0

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptBlueprint toast component
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The bug is in the Toast component's timeout handling. Investigate the toast.tsx file to see how the dismiss timer is set up and how the `onFocus` handler triggers early dismissal. The issue is that when timeout is 0 or Infinity, the component incorrectly dismisses on focus. The fix likely involves treating 0 as infinite timeout (like `Infinity`) and ensuring the focus dismissal logic checks for these values. Look at the conditional in the timer setup and the `handleFocus` function.