palantir/blueprint

TODO: Use react-focus-lock in overlay component

Open

#6,676 创建于 2024年1月25日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: enhancementhelp wanted

描述

Environment

  • Package version(s): core v5.9+

Feature request

Follow-up to Overlay2 PR https://github.com/palantir/blueprint/pull/6656

We should try to use the react-focus-lock library to replace a bunch of bespoke focus management code dealing with focus traps and document event handlers.

贡献者指南

技术栈
typescriptreact
领域
frontendaccessibility
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ReactTypeScriptFocus managementBlueprint Overlay2 PR #6656
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the Overlay2 PR #6656 to understand the existing focus management code. Examine the current overlay component to identify the bespoke focus trap logic that can be replaced. Then integrate react focus lock by wrapping the overlay content with its FocusLock component, removing the custom event handlers. Ensure existing tests still pass and accessibility is preserved.
TODO: Use react-focus-lock in overlay component · palantir/blueprint#6676 | Good First Issue