palantir/blueprint

EditableCell2 doesn't rerender to empty cell on sort.

Open

#6,602 创建于 2023年12月13日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Package: tableStatus: needs proposalType: bughelp wanted

描述

Environment

  • Package version(s): "@blueprintjs/core": "^5.5.1", "@blueprintjs/table": "^5.0.20",
  • Operating System: Windows 11
  • Browser name and version: Firefox 120.0.1 (64 bit), Chrome 120.0.6099.71 (64 bit)

Code Sandbox

demo

Steps to reproduce

  1. Create some table data with some undefined values.
  2. Create a sortable Table2 whose cells are EditableCell2.
  3. Sort columns with undefined cells. When a cell value changes from some value to undefined, it does not re-render to a blank cell.

Actual behavior

EditableCell2 does not re-render when its value changes from some value to undefined.

Expected behavior

The cell re-renders into a blank cell whenver the value changes to undefined.

Possible solution

.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with ReactUnderstanding of Blueprint table components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
First, locate the EditableCell2 component in the Blueprint table package (likely in packages/table/src/components/editableCell/editableCell.tsx). Investigate how the cell renders its value and whether it uses React.memo or shouldComponentUpdate to prevent re renders when the value changes. The issue is that sorting triggers a re render but the cell does not update when the value becomes undefined. Look for comparisons that treat undefined and a previous string as equal, perhaps due to shallow checking or missing dependency in useEffect.
EditableCell2 doesn't rerender to empty cell on sort. · palantir/blueprint#6602 | Good First Issue