palantir/blueprint

ESLint deprecated component usage detector does not handle aliased imports

Open

#6,408 创建于 2023年9月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: toolingP2Type: bughelp wanted

描述

Environment

  • Package version(s): @blueprintjs/eslint-plugin: 5.0.0
  • Operating System: Windows 10/11

Steps to reproduce

  1. Use an aliased import of a deprecated BlueprintJS component somewhere:

import { DateInput as BlueprintDateInput } from "@blueprintjs/datetime";

  1. Use "plugin:@blueprintjs/recommended" in your eslintrc file.

Actual behavior

No errors detected.

Expected behavior

A message which tells that the usage of DateInput is deprecated.

  71:6  error  Usage of DateInput is deprecated, migrate to DateInput3 instead  @blueprintjs/no-deprecated-components

The error is properly displayed if we change the aliased import to a non-aliased import.

贡献者指南

技术栈
typescriptreact
领域
frontendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of ESLint plugin developmentFamiliarity with TypeScript AST
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the ESLint rule implementation in @blueprintjs/eslint plugin, likely in the src/rules/no deprecated components directory. The rule needs to handle aliased imports by checking ImportSpecifier nodes where the imported name matches deprecated components, regardless of the local alias. Look for the function that processes ImportDeclaration and modify it to also capture aliased imports. Consider testing with cases like 'import { DateInput as BlueprintDateInput }'.