palantir/blueprint

`eachUniqueFullRow` crashes with header row shift-click

Open

#6,383 创建于 2023年9月15日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: tableType: bughelp wanted

描述

Environment

  • Package version(s): 5.3.0
  • Operating System: MacOS
  • Browser name and version: Chrome 117

Steps to reproduce

  1. Pass a region of { row: [1, Infinity] } to eachUniqueFullRow (this can be caused for example by shift-clicking on a row header cell + using eachUniqueFullRow in the onSelect.

Actual behavior

Spins until tab crashes

Expected behavior

Short circuit or error

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic understanding of Blueprint table componentFamiliarity with the issue's reproduction steps
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the `eachUniqueFullRow` function in the Blueprint table source code, likely in the selection utilities (e.g., src/components/table/). Look for how it handles row ranges and specifically when `Infinity` is passed. Consider adding a guard to check for `Infinity` or bound the row range to the actual number of rows. Check existing tests for similar edge cases.