palantir/blueprint

Dynamic imports false positive on class-constants ESLint rule

Open

#6,209 创建于 2023年6月7日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: toolingP2Type: bughelp wanted

描述

Normal imports don't seem to be impacted by this, though dynamic imports are. Packages imported dynamically that include pt in their name seem to trigger an ESLint rule related to Blueprint.

root@______ # ./gradlew :subproject:eslint

> Task :subproject:eslint
error: use Blueprint `Classes` constant instead of string literal (@blueprintjs/classes-constants) at <redacted_filename>:

  49 | 
> 50 |         const { compileTypeScript } = await import("@example/pt-typescript");
     |                                                    ^

1 error found.
1 error potentially fixable with the `--fix` option.

> Task :subproject:eslint FAILED

FAILURE: Build failed with an exception.```

贡献者指南

技术栈
typescriptreact
领域
frontenddeveloper experiencetooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
knowledge of ESLint rulesunderstanding of Blueprint Classes constants
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the ESLint rule `@blueprintjs/classes constants` to understand why dynamic imports containing 'pt' trigger a false positive. Look at the rule implementation (likely in the Blueprint monorepo under packages/classes constants) and check if the regex or string matching logic incorrectly flags string literals inside dynamic import expressions. Consider adding a test case for dynamic imports to confirm the bug and then adjust the rule to skip dynamic import statements.