palantir/blueprint

Expanding a tree with many child nodes that have ContextMenu is very slow

Open

#6,204 创建于 2023年6月6日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: performanceP2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): The latest @blueprintjs/core@4.20.1, @blueprintjs/popover2@1.14.9
  • Operating System: macOS
  • Browser name and version: Edge/Chrome

Code Sandbox

https://codesandbox.io/p/sandbox/festive-rgb-j35zpp

Actual behavior

If the tree node has many children nodes, and these children nodes are wrapped with ContextMenu2, when expanding the tree node, it's stuck for seconds to expand its children. If the ContextMenu2 is removed, the expanding is very smooth.

The sandbox uses the treeExample from the blueprint itself and makes a little change to demonstrate this problem.

贡献者指南

技术栈
typescriptreact
领域
frontendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactPerformance debuggingTree componentContextMenu
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Reproduce the slowdown using the provided CodeSandbox (https://codesandbox.io/p/sandbox/festive rgb j35zpp). Profile the tree expansion with React DevTools to pinpoint the culprit. Inspect the Tree and ContextMenu2 source code in the Blueprint repository to understand the rendering flow. Consider using React.memo or virtualization to reduce the number of context menus rendered at once.