palantir/blueprint

Add shouldReturnFocusOnClose property to Toaster

Open

#6,018 创建于 2023年3月14日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: feature requesthelp wanted

描述

I see that in this ticket #5032 there was removed a feature of returning focus to previously focused element when toaster is closed. But actually I need this for my case. Could the property "shouldReturnFocusOnClose " be added to Toaster, so I developer could deside wether they want or not focus to be returned to previous active element? So it would be like that toaster.show({ message: message, shouldReturnFocusOnClose: true })

To do this, just a simple change need to be done. "render" function in "toaster.tsx" should pass this property to Overlay's shouldReturnFocusOnClose; instead of setting it to "false".

贡献者指南

技术栈
reacttypescript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React knowledgeTypeScript knowledgeBlueprint Toaster API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue requests adding a shouldReturnFocusOnClose prop to the Toaster component. The implementation involves modifying the render function in toaster.tsx to pass this prop to the Overlay component instead of hardcoding false. Reference the previous ticket #5032 for context on why the focus return was removed. Check the Overlay component's shouldReturnFocusOnClose prop and ensure backward compatibility (default false). Also consider updating documentation and tests.