palantir/blueprint

Mouse Event onChange Slider

Open

#5,916 创建于 2023年2月1日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: feature requesthelp wanted

描述

Improve Slider in Blueprint

Slider onChange does not have mouse event as a return value. Would be nice to add it, cause we cannot stop the propagation of the event.

Current: onChange={(value) => console.log(value); }

Expected: onChange={(value, e) => console.log(value); e.stopPropagation()}

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of ReactFamiliarity with TypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Look at the Blueprint Slider component implementation. The onChange callback currently only passes the value. The change involves adding an event parameter (type React.SyntheticEvent) to the callback signature and propagating it from the internal handlers. Check the Slider's source files, likely in src/components/slider, and update the type definitions and tests accordingly.