palantir/blueprint

DateRangeInput2 TimePicker does not appear to respect minimum datetime

Open

#5,859 创建于 2023年1月20日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): v4.14.2
  • Operating System: macOS Ventura
  • Browser name and version: Chrome v109.0.5414.87

Code Sandbox

https://codesandbox.io/s/daterangeinput2-example-iwv0ln?file=/src/DateRangeInput2Example.tsx

Steps to reproduce

  1. On DateRangeInput2, set minDate and time picker minTime values to equal current time.
  2. Select a date range in the popover
  3. Observe that the min date and time is respected in the popover while the minTime value is ignored in the subsequent value produced by the onChange handler if the time value is not changed.

https://user-images.githubusercontent.com/2968519/213801179-0ecaa359-8ead-47eb-929c-4216bb0457d2.mp4

Actual behavior

When selecting a date range, the time always defaults to 12:00AM of the selected day which is often out of range if the minimum date time is set to the current time.

Expected behavior

I expected both the date and time to respect the minDate property since it is provided as a Date (which includes time). This would be helpful, for example, to constrain the range selection to both a minimum day and specific time (e.g. "Jan 20th after 12:00PM)

Possible solution

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptDate manipulation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue describes that DateRangeInput2 ignores the minTime when selecting a date range. The code sandbox provided (https://codesandbox.io/s/daterangeinput2 example iwv0ln) can be used to reproduce the bug. The fix likely involves ensuring that the minDate property (which includes time) is respected when setting the initial time in the date range. Investigate the DateRangeInput2 component in the Blueprint repository, particularly how it handles time values and minDate constraints. Check if the time picker's minTime is being properly propagated or if there is a missing state initialization.