palantir/blueprint

Alert doesn't support usePortal and portalClassName TS definitions, but they work fine

Open

#5,801 创建于 2022年12月13日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: APIP3Package: coreType: feature requesthelp wanted

描述

Environment

  • Package version(s): 4.13.0
  • Operating System: Windows 11
  • Browser name and version: Chrome latest

Steps to reproduce

Use the usePortal prop on a Blueprint TSX project. A red error message displays the message Property 'usePortal' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Alert> & Pick<Readonly<IAlertProps>, never> & InexactPartial<...> & InexactPartial<...>'..

The Blueprint docs at https://blueprintjs.com/docs/#core/components/alert and https://github.com/palantir/blueprint/blob/develop/packages/core/src/components/alert/alert.tsx don't mention these two props either. But forcing compilation works and it's clear from DevTools that usePortal works fine.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptReactBlueprint component knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Add `usePortal?: boolean` and `portalClassName?: string` to the IAlertProps interface in packages/core/src/components/alert/alert.tsx. Update the component's documentation to list these props. Refer to similar props in other Blueprint components for consistency.