palantir/blueprint

Locale = English does not display comma separators

Open

#5,405 创建于 2022年6月28日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: feature requesthelp wanted

描述

https://blueprintjs.com/docs/#core/components/numeric-input Typing "1000000" with locale set to English does not convert the display format to "1,000,000", contrary to https://github.com/palantir/blueprint/blob/develop/packages/docs-app/src/examples/core-examples/common/locales.tsx#L20

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Blueprint's NumericInput componentBasic understanding of JavaScript Intl.NumberFormat
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Examine the locale.tsx file (packages/docs app/src/examples/core examples/common/locales.tsx) to understand the locale configuration. Then review the NumericInput component implementation, likely in packages/core/src/components/numeric input, to see how number formatting is applied. Check if Intl.NumberFormat is used and whether the issue is due to missing options for grouping separators. Also look at the comments on the issue for any additional context or hints from maintainers. If possible, test the behavior with different locales.