palantir/blueprint

[webpack-build-scripts] asset file name generator is missing query delimiter

Open

#5,296 创建于 2022年5月10日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: toolingP2Type: bughelp wanted

描述

Environment

  • Package version(s): @blueprintjs/webpack-build-scripts v3.2.1
  • Browser: Chrome

Actual behavior

When using webpack-build-scripts' base config outside this repo, asset files like SVGs are being generated in the bundle with paths like assets/logo-black.svgccef1ff6a39afed7ae4a, which prevent browsers like Chrome from interpreting them according to their file extension.

Expected behavior

The file extension should be preserved in these webpack asset URLs

Possible solution

Add a ? in the file name generator

贡献者指南

技术栈
typescriptreact
领域
build systemtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptwebpack
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Locate the webpack configuration file in the @blueprintjs/webpack build scripts package. Look for the file name generator configuration, likely in a file like `webpack.base.js` or similar. Add a '?' delimiter between the base name and the hash to ensure the file extension is preserved. Verify by running the build and checking that asset paths contain a '?' before the hash.