palantir/blueprint

[node-build-scripts] es-lint path logic is broken

Open

#5,295 创建于 2022年5月10日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: toolingP2Type: bughelp wanted

描述

similar to https://github.com/palantir/blueprint/issues/4942

Environment

  • Package version(s): node-build-scripts v2.0.x

Steps to reproduce

use es-lint script outside this repo, in CircleCI where JUNIT_REPORT_PATH variable is present in the environment

Actual behavior

the utility function junitReportPath() returns a path within node_modules/reports/, which is wrong

Expected behavior

The script is usable outside this repo

Possible solution

Use process.cwd() instead of __dirname

贡献者指南

技术栈
typescriptnodejs
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of Node.jsunderstanding of dirname and process.cwd
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The fix is to replace dirname with process.cwd() in the junitReportPath() function. Locate the file containing this function within the node build scripts package. Ensure the change applies only when running outside the repo; consider adding a test if applicable.