palantir/blueprint

[node-build-scripts] sass-lint path logic is broken

Open

#4,942 创建于 2021年9月30日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: toolingP2Type: bughelp wanted

描述

Environment

  • Package version(s): node-build-scripts v1.6.x

Steps to reproduce

  1. Use sass-lint.js script outside of this repo, through @blueprintjs/node-build-scripts

Actual behavior

It always fails to find .stylelintrc because it's looking inside the node_modules folder where the scripts package is installed.

Expected behavior

The script is usable outside this repo...

Possible solution

Use process.cwd() instead of __dirname, and also allow a CLI argument to override the configFile option

贡献者指南

技术栈
javascriptnodejs
领域
build systemdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
node.jsprocess.cwd()cli arguments
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The script uses dirname to find .stylelintrc, which fails when used externally. The fix is to replace dirname with process.cwd() and optionally accept a config CLI argument. The relevant file is likely sass lint.js in the node build scripts package. No discussion has occurred, so first time contributors should verify with maintainers before working.