palantir/blueprint

Default overlay leave transition does not fade content nicely

Open

#4,923 创建于 2021年9月21日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: enhancementhelp wanted

描述

Environment

  • Package version(s): 3.49.1

Code Sandbox

Link to a minimal repro https://codesandbox.io/s/blueprint-overlay-ktx4f?file=/src/index.tsx

Steps to reproduce

  1. Open overlay with button
  2. click outside overlay to close it
  3. the backdrop fades but the card hangs for a second and then disappears in a very clunky transition

Expected behavior

The default transition should match the fade of the backdrop so that it looks nice. The docs use a custom transition. It would be nice to cleanup the default transition and use that instead.

Possible solution

贡献者指南

技术栈
typescriptreactcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React basicsCSS transitions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the Overlay component in the Blueprint source code, likely in packages/core/src/components/overlay. The default transition classes (e.g., pt overlay enter, pt overlay leave) need to be adjusted to match the fade timing of the backdrop. Check the transition definitions in the CSS files. The docs mention a custom transition; consider aligning the default with that.