palantir/blueprint

Numeric input - Basic example: page crash on selecting default locale

Open

#4,876 创建于 2021年8月25日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)TypeScript (2,167 fork)batch import
Domain: documentationP2Type: bughelp wanted

仓库指标

Star
 (20,263 star)
PR 合并指标
 (平均合并 43天 10小时) (30 天内合并 27 个 PR)

描述

https://github.com/palantir/blueprint/blob/2db16b00fcf4f9eeb2defb0cb4f5b43a19c10762/packages/docs-app/src/examples/core-examples/numericInputBasicExample.tsx#L157

Low prio

In the docs section for Numeric input - Basic example, selecting any option in the Locale selector, then going back to default option results in page crash due to incorrect locale information provided.

Current: [{ label: "Default", value: "" }, ...LOCALES]

Expected: [{ label: "Default", value: "en-US" }, ...LOCALES] Suggesting "en-US" as convenience fallback.

cc: @adidahiya

贡献者指南