palantir/blueprint

Numeric input - Basic example: page crash on selecting default locale

Open

#4,876 创建于 2021年8月25日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: documentationP2Type: bughelp wanted

描述

https://github.com/palantir/blueprint/blob/2db16b00fcf4f9eeb2defb0cb4f5b43a19c10762/packages/docs-app/src/examples/core-examples/numericInputBasicExample.tsx#L157

Low prio

In the docs section for Numeric input - Basic example, selecting any option in the Locale selector, then going back to default option results in page crash due to incorrect locale information provided.

Current: [{ label: "Default", value: "" }, ...LOCALES]

Expected: [{ label: "Default", value: "en-US" }, ...LOCALES] Suggesting "en-US" as convenience fallback.

cc: @adidahiya

贡献者指南

技术栈
reacttypescript
领域
frontenddocumentation
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The crash occurs in packages/docs app/src/examples/core examples/numericInputBasicExample.tsx at line 157. The fix is to change the default locale value from an empty string to 'en US' in the select options. Verify by running the docs app locally and testing that selecting any locale then back to Default does not crash the page.