palantir/blueprint

FR: InputGroup aria-label can be inferred from placeholder

Open

#4,874 创建于 2021年8月24日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: accessibilityP2Type: feature requesthelp wanted

描述

Environment

  • Package version(s): core 3.48.0

Feature request

<InputGroup> could have better accessibility if it applied an aria-label to its <input>. If the placeholder prop exists, we should use that value. We'll need to consider how this interacts with <FormGroup> and wrapping <label> elements (we don't want to label the input twice).

贡献者指南

技术栈
typescriptreacthtmlcss
领域
frontendaccessibility
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactAccessibility basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The main file to modify is packages/core/src/components/input group/inputGroup.tsx. Look for the <input> element and add an aria label attribute that uses the placeholder prop when no label is provided. Consider the interaction with FormGroup by checking if the input is already labeled via a wrapping <label> or FormGroup's label prop. Review the FormGroup component in packages/core/src/components/form group/formGroup.tsx to understand how labeling works. Ensure not to duplicate aria labels.
FR: InputGroup aria-label can be inferred from placeholder · palantir/blueprint#4874 | Good First Issue