[MultistepDialog] Navigation to later steps is allowed via side navigation when `nextButtonProps` disallows it · palantir/blueprint#4871

(0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import

P2Package: coreType: bughelp wanted

描述

Environment

Package version(s): @blueprintjs/core@3.48.0

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d

Steps to reproduce

(Using the example in the Code Sandbox)

Advance through each step of the <MultistepDialog> to the end.
See how each step must be "valid" before you can progress.
Before submitting, go back to an earlier step via the "Back" buttons or via the side navigation.
Uncheck the checkbox to make the step invalid.
✅ See that the "Next" button on the step is now disabled (according to nextButtonProps on that step)
❌ See that you can still navigate to the next step via the side navigation, as it was previously visited.

Actual behavior

Expected behavior

If the "Next" button of the current <DialogStep> is disabled through the nextButtonProps, I do not expect to be able to navigate further forwards through the steps via the side navigation; even if I have advanced further previously.

贡献者指南

技术栈: typescriptreact
领域: frontend
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: Familiarity with Blueprint's MultistepDialogBasic React understanding
新手友好度: 60
研究方向: Investigate the step navigation logic in MultistepDialog, likely in packages/core/src/components/dialog/multistepDialog.tsx. The side navigation clicks probably call a handler like handleStepClick that advances steps without checking if nextButtonProps is disabled. Modify this handler to check the current step's nextButtonProps.disabled before allowing forward navigation. Also ensure that step validity (e.g., checkbox state) is re evaluated when navigating via side panel. Refer to the CodeSandbox for reproduction steps and expected behavior.