palantir/blueprint

The default value of showDialogKeyCombo (?) only works in certain keyboard layouts

Open

#4,849 创建于 2021年8月9日

在 GitHub 查看
 (9 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: accessibilityDomain: i18nP2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): @blueprintjs/core 3.47.0
  • Operating System: Ubuntu 21.04
  • Browser name and version: Electron 13.1.8 (reproduces on Chrome 92.0.4515.107 as well)

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#core/hooks/use-hotkeys (yes, that's your own documentation, it also reproduces there)

Steps to reproduce

  1. Set your keyboard layout to Spanish (example)
  2. Focus the piano on the documentation.
  3. Try to open the key combo dialog by typing ?.

Actual behavior

Nothing. The ? doesn't get registered. It also doesn't work as a regular "combo" in HotkeyConfig.

Note that Electron and Chrome both catch that key if you use document.body.onkeydown. Also, on gmail, the ? hotkey works well with my layout.

Expected behavior

The key combo dialog opens.

Possible solution

If I set my keyboard layout to English/US, then ? works, both in showDialogKeyCombo as well as HotkeyConfig. Of course this is not a great workaround... I can't just ask all my users to change their keyboard layout to use my app. I don't know the blueprint codebase well enough to propose other alternatives. Happy to help with debugging if you point me in the right direction.

贡献者指南

技术栈
typescriptreact
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
understanding of keyboard eventsknowledge of keyboard layout differences
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate how the '?' hotkey is captured in the use hotkeys hook. The issue suggests that event.key may differ across keyboard layouts while event.code remains constant. Look at the implementation in src/hooks/hotkeys/ to see if event.key is used. Test with different keyboard layouts to confirm. Consider using event.code with a mapping or checking for the slash key irrespective of layout. Review comments on the issue for any hints.