palantir/blueprint

LabelElement Icon doesn't highlight on hover in dark mode

Open

#4,809 创建于 2021年7月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: coreType: bughelp wanted

描述

Environment

  • Package version(s): 3.46.0
  • Operating System: MacOS Catalina
  • Browser name and version: Chrome

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#core/components/menu

Steps to reproduce

View the menu item behavior shown in the link above. This is just a comment on the current features of the menu item component.

Actual behavior

The right icon (labelElement) does not highlight on hover in dark mode unlike the left icon.

Expected behavior

The right icon should highlight on hover in dark mode like the left icon, at least for cases where there is only the right icon being rendered.

Possible solution

Add a highlight styling on hover for the labelElement.

贡献者指南

技术栈
cssreacttypescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic CSSfamiliarity with Blueprint theming
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The fix involves adding a CSS rule for the labelElement hover state in dark mode. Look at the Menu component's styles, likely in the `packages/core/src/components/menu/` directory. The issue suggests adding a hover style similar to the left icon's hover effect. Check the existing hover styles for menu items and replicate for `.bp3 menu item .bp3 file label` (or similar selector) in dark mode. No linked PR or assignee, so the issue is available for contribution.