palantir/blueprint

Popover v2 always take focus even if autoFocus is disabled

Open

#4,792 创建于 2021年7月2日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: popover2Type: bughelp wanted

描述

Environment

  • Package version(s): "@blueprintjs/core": "^3.46.0", "@blueprintjs/popover2": "^0.11.0",
  • Operating System: Mac OS, Big Sur 11.4
  • Browser name and version: Chrome Version 91.0.4472.114 (Build officiel) (x86_64)

Code Sandbox

https://codesandbox.io/s/restless-dust-b4ggf?file=/src/App.tsx

Context

I'm trying to create a component that behave close to Suggest but i can't rely on InputGroup. I try to build my own version but i'm blocked with popover v2 because focus is always take by the popover even if autoFocus props is marked as false.

Actual behavior

Input lose focus when popover open or close event if autoFocus is disabled.

Expected behavior

When autoFocus is disabled popover is not focus when open or close.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptBlueprintJS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Focus on the Popover2 component source in the @blueprintjs/popover2 package. Investigate the autoFocus prop handling in the open/close logic, specifically where focus is programmatically set. Check the Overlay component as it might manage focus. The issue reports that focus is always taken even when autoFocus is disabled; likely a missing conditional check.