palantir/blueprint

DateRangePicker with singleMonthOnly enabled sometimes shows wrong month after selecting shortcut

Open

#4,526 创建于 2021年2月15日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): v3.38
  • Operating System: Linux/Windows
  • Browser name and version: Google Chrome v88

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-forked-j4ooz?file=/src/index.tsx

Steps to reproduce

ezgif-3-4c479ecd4a65

  1. Select (Past month) shortcut
  2. Select any of the smaller ranges shortcut from shortcut menu (Past week, Yesterday, Today)
  3. The selected range will not appear in the single month shown

Actual behavior

Selected range is inconsistent after toggling from past month to current week/day ranges from shortcut menu in single-month mode only.

Expected behavior

The calendar should show the month where the currently selected range is, instead of the previous one.

Possible solution

Not sure about the solution. Switching from past 3 month to current week/day works fine. Showing ending month as default may not also not be a correct solution as for higher ranges(6month,1 year), it will show the current month.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ReactTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the DateRangePicker component, specifically the logic for selecting shortcuts when singleMonthOnly is enabled. The issue suggests that switching from a past month shortcut to a current week/day shortcut does not update the displayed month correctly. Look at the shortcut selection handler and month navigation logic in the source file (likely src/components/date range picker/). Check if there is an existing fix or related PR mentioned in comments.