palantir/blueprint

DateRangeInput placeholder not working

Open

#4,487 创建于 2021年1月20日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: enhancementhelp wanted

描述

Environment

  • Package version(s): @blueprintjs/datetime 3.18.5
  • Operating System: macOS Big Sur Version 11.1
  • Browser name and version: Chrome Version 87.0.4280.141 (Official Build) (x86_64)

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-rk722?file=/src/DatetimeExample.tsx

Steps to reproduce

Specify placeholder on DateRangeInput e.g. "Please enter date"

Actual behavior

Placeholders say "Start date" and "End date"

Expected behavior

Placeholders should be the specified string e.g. "Please enter date"

Possible solution

Since there are two fields, the placeholder should be [string, string] for the start date and end date respectively

贡献者指南

技术栈
reacttypescriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptBlueprint.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the DateRangeInput component in packages/datetime/src/dateRangeInput.tsx. The placeholder prop currently accepts a single string but should accept a tuple [string, string] for start and end dates. Check the component's prop typing and rendering logic to implement the fix. The issue also suggests updating documentation if applicable.