palantir/blueprint

MultiSelect triggers wrapping form

Open

#4,461 创建于 2020年12月17日

在 GitHub 查看
 (2 评论) (5 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Form componentsP2Package: corehelp wanted

描述

Environment

  • Package version(s): select 3.15.0
  • Operating System: Docker / node 14
  • Browser name and version: Chrome latest

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-forked-cnc83?file=/src/index.tsx

Steps to reproduce

  1. Create a MultiSelect
  2. Place it inside a form
  3. Select a value, confirm with enter

Actual behavior

The form is submitted.

Expected behavior

The value is added to the tag list and the form remains un-submitted.

Possible solution

Doing event.stopPropagation and event.preventDefault in the onItemSelect handler does not help. Same with overriding tagInputProps.onChange.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Reactevent handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate MultiSelect component's key event handling in packages/select/src/components/multi select/multiSelect.tsx. Focus on how the Enter key is processed and whether event.preventDefault is correctly called. Check if the form submission is triggered by a missing stopPropagation on the keydown event. Also review any existing comments or linked issues for insights.