palantir/blueprint

Date Range Input: Time is not updating onHoverChange event

Open

#4,402 创建于 2020年11月8日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: bughelp wanted

描述

Environment

  • Package version(s): 3.30.1
  • Operating System: MAc OS Catlina
  • Browser name and version: Chrome latest

Code Sandbox

Actually the bug can be visible in the documentation itself so adding Screenshot of it here

Steps to reproduce

Enable Time Precision with minute or seconds

  1. Click Start Date Field (so Date Picker opens).
  2. Select preferred date for both start and end fields.
  3. Please Add time in the below boxes for hours, minutes, seconds.
  4. Now Hover the different date in Date Picker and you can see start date in input field changes as per the hover state but the time value will be the default time itself (12:00)
  5. The same happens in end date field too.

Actual behavior

As we can clearly see the time is not changing and stays still with 12:00 during hovering of dates

Expected behavior

We should get the time from the value and update the time too when we hover Defaulting to 12:00 and changing immediately back to user selected time causes confusion

Possible solution

DateRangePicker props and callback function should be updated with props time i guess

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptDateRangePicker API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the DateRangePicker component, specifically the onHoverChange event handler. Check how time values are preserved during hover. Look at the source code for DateRangePicker in the Blueprint repository, likely in the 'packages/date time' folder. Review the props and state management for time precision settings. Consider if the time should be taken from the already selected value instead of defaulting to 12:00.