palantir/blueprint

TagInput should have a string-only variant with simpler prop types

Open

#4,390 创建于 2020年10月27日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Package: coreType: enhancementhelp wanted

描述

Working with onRemove: (value: React.ReactNode, index: number) is inconvenient under TypeScript's strict compiler options. Even when the values prop is string[], you are either forced to type cast the removed value to string or use the index parameter to index into your values array. We should make the simple case easier to work with, either with a new component API or changing the existing component to be parameterized by its data type <T>.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React component developmentTypeScript genericsFamiliarity with TagInput API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Implement a generic version of TagInput where the value type can be specified. The existing component in packages/core/src/components/tag input/tagInput.tsx needs to be updated to accept a generic type parameter T. The onRemove callback should infer the type from the values array. Consult the repository's contribution guidelines and existing similar patterns in the codebase (e.g., other generic components). A pull request should be opened with changes to the component and its TypeScript definitions.
TagInput should have a string-only variant with simpler prop types · palantir/blueprint#4390 | Good First Issue