palantir/blueprint

ItemPredicate make onActiveItemChange fired twice and active item isn't the good one

Open

#4,192 创建于 2020年6月25日

在 GitHub 查看
 (4 评论) (5 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: selectType: bughelp wanted

描述

Environment

  • Package version(s): 3.28.1
  • Operating System: Mac OS - latest
  • Browser name and version: chrome Version 83.0.4103.106 (Build officiel) (64 bits)

Steps to reproduce

  1. Define a Select component with a custom item list render and item render
  2. Add itemPredicate function
  3. select an item
  4. Open the Select back ( active item isn't item selected )

Actual behavior

I don't know why but onActiveItemChange is fired twice when a itemPredicate is defined. First you get the selected item and just after onActiveItemChange is fired with the first item in the list with no reason.

Expected behavior

ActiveItem is the selected item when you open the list after a select.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ReactBlueprint Select component
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the onActiveItemChange callback in the Select component, specifically how itemPredicate affects active item state. Look at the source code in packages/core/src/components/select/select.tsx and related handler functions. Check if active item reset occurs when predicate filters the list, causing the first item to become active incorrectly.
ItemPredicate make onActiveItemChange fired twice and active item isn't the good one · palantir/blueprint#4192 | Good First Issue