palantir/blueprint

Add active menu styles to shortcuts for Date Range input

Open

#4,052 创建于 2020年4月9日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: enhancementhelp wanted

描述

Environment

  • Package version(s): 3.15.2
  • Browser and OS versions: Chrome

Feature request

Expose selectedShortcutIndex and onShortcutChange props to DateRange Input, similar to DateRangePicker

Examples

I'm looking to use DateRangeInput to allow selection of month(s) at a time. Usually, the users are interested in current month, and forward and backward a couple of months. Hence I'm providing them dynamic shortcuts, depending on their current month selection. Since the selected shortcut index isn't exposed, the component erroneously shows the previous month being selected. The shortcuts to months are dynamically generated, so when April is selected it looks so:

image

And when March is selected, and then re-opening it, the page loads with February selected since it is now at index 1: image

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptBasic understanding of Blueprint components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the existing DateRangePicker implementation for similar props (see PR #3688). Locate the DateRangeInput component source code in Blueprint's date time package. Add 'selectedShortcutIndex' and 'onShortcutChange' props analogous to DateRangePicker, ensuring TypeScript types are updated and component behavior matches. Finally, update or add tests to cover the new functionality.
Add active menu styles to shortcuts for Date Range input · palantir/blueprint#4052 | Good First Issue