palantir/blueprint

FR: components should be able to operate in child window documents

Open

#3,972 创建于 2020年2月19日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Package: coreType: feature requesthelp wanted

描述

currently, some components like (e.g. NumericInput) reference window.document implicitly, which can may not be the document of the window where the component is being rendered in the case of React portal techniques like this one. we should look into supporting this use case.

possible solution: define a blueprint React context which includes an optional field which sets this.document on all components

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with React ContextUnderstanding of React portal behaviorBasic knowledge of Blueprint component architecture
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue proposes a React context to allow components to reference a custom document object for child window support. The main file to examine is `packages/core/src/components/forms/numericInput.tsx` where `window.document` is used implicitly. The goal is to introduce a context with an optional `document` field and update components to use it. No linked PRs or existing work; the issue remains open with no comments. A newcomer should first understand how Blueprint uses React context (e.g., for theming) and then prototype a solution that overrides the document reference in components like NumericInput.