palantir/blueprint

Popover's boundary prop does not accept Element objects

Open

#3,570 创建于 2019年5月27日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: bughelp wanted

描述

Package: @blueprintjs/core@3.15.1

Issue: The boundary field of IPopoverSharedProps (defined here) does not accept values of type Element.

Description: This field (boundary) is only used as the boundariesElement field in flip and preventOverflow objects in Popper modifiers, as seen here. Both of these fields in Popper (defined here and here) accept objects of type Boundary | Element, but the boundary field defined in Blueprint only accepts Boundary.

Possible Solution: Change the type here from PopperBoundary to PopperBoundary | Element.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptReact
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Change the type definition in `packages/core/src/components/popover/popoverSharedProps.ts` line 42 from `PopperBoundary` to `PopperBoundary | Element`. Ensure consistency with Popper.js types referenced in the issue. Test that the component accepts Element objects without breaking existing usage.
Popover's boundary prop does not accept Element objects · palantir/blueprint#3570 | Good First Issue