palantir/blueprint

Dev mode warning for Tooltip wrapping a disabled Button

Open

#3,494 创建于 2019年4月23日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Domain: APIP2Package: coreType: enhancementhelp wanted

描述

Even though it's well-documented, the issue comes up frequently: https://github.com/palantir/blueprint/issues/967#issuecomment-485615346

We should log a warning in development mode, suggesting use of an AnchorButton instead. Writing a lint rule seems like it would be harder than introspecting the React tree at runtime.

cc @thelastnode

贡献者指南

技术栈
reacttypescript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactBlueprint componentsTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Implement a dev mode warning in the Tooltip component that checks if its children include a disabled Button. Inspect the Tooltip component source in the Blueprint repository (likely in packages/core/src/components/tooltip). Use React.Children or React.Children.forEach to iterate over children and check if any element is a Button with disabled prop. If so, log a warning suggesting AnchorButton. Look at existing dev warnings in Blueprint (e.g., using the debug package or process.env.NODE ENV) to maintain consistency.