palantir/blueprint

Suggest Component should have an easy way to prevent an empty menu from showing.

Open

#3,425 创建于 2019年3月16日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: selectType: bughelp wanted

描述

Hey @giladgray @adidahiya image

In the above image I have a <Suggest/> with the prop

initialContent={null}

Instead of showing the weird little empty menu, I'd rather not show anything. There doesn't seem to be an easy way to do this besides implementing an entire itemListRenderer override. I think that passing initialContent={null} should completely hide the Menu.

To do that all that would seemingly need to change is here:

https://github.com/palantir/blueprint/blob/3d6f13e8af98225ad8ca5ea6309bb406fd218b3e/packages/select/src/components/query-list/queryList.tsx#L264

If we added the this

if (menuContent === null && createItemView === null) {
  return null
}

to the next line then that weird empty menu wouldn't show up.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Review the file `packages/select/src/components/query list/queryList.tsx` around line 264. Check the current logic for rendering menu content and implement the suggested null check to hide the menu when `initialContent` is null. Ensure that the change does not break other scenarios where `menuContent` might be validly null in conjunction with `createItemView`.
Suggest Component should have an easy way to prevent an empty menu from showing. · palantir/blueprint#3425 | Good First Issue