palantir/blueprint

FileInput should support "directory" prop

Open

#3,126 创建于 2018年11月5日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: feature requesthelp wanted

描述

Environment

  • Package version(s): not applicable
  • Browser and OS versions: not applicable

Feature request

FileInput does not support mozdirectory, directory, webkitdirectory or nwdirectory.

Per https://github.com/facebook/react/issues/3468#issuecomment-328197124 React does not support this specifically but the props can be added.

This feature allows selecting a directory itself vs files inside a directory.

Examples

Instead of having to define all 4 props above, directory could be used to add all at once.

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptBasic knowledge of Blueprint components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The FileInput component likely resides in the blueprint repository under `packages/core/src/components/file input/`. The prop should accept a boolean and add the necessary attributes to the underlying `<input>` element. Consider following the existing pattern for other props. The linked React issue (facebook/react/issues/3468) provides context. No linked PR or assignee, so the work is available.