palantir/blueprint

Using EditableText in selected tree element leads to unreadable text

Open

#2,236 创建于 2018年3月14日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Package: coreType: bughelp wanted

描述

Bug report

  • Package version(s):
    "@blueprintjs/core": "^2.0.0-rc.2",
    "@blueprintjs/icons": "^2.0.0-rc.2",
    "@blueprintjs/table": "^2.0.0-rc.2",
  • Browser and OS versions: Chrome 64.0.3282.186 on OS X

Steps to reproduce

  1. Create
  2. Add child element with EditableText as label
  3. Select element and start editing

Actual behavior

The editable text is unreadable because it's white text on white background.

style-problem

Expected behavior

Visibly different colors for text and background.

Shouldn't pt.editable-text.pt-editable-editing set the text-color when setting the background-color? Setting only one of them sounds like inviting this kind of problems.

贡献者指南

技术栈
typescriptreactcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSSReact
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Investigate the CSS for the Tree component's selected state. The issue describes that when using EditableText as a label in a selected tree element, the text becomes unreadable due to white text on white background. Look at the CSS selector `.pt editable text.pt editable editing` and ensure that both `color` and `background color` are set appropriately. The fix likely involves adding a specific color override for the editing state within the selected tree element. Check the relevant SCSS files in the Blueprint codebase, such as those for Tree and EditableText components.