palantir/blueprint

NumericInput - prevent exceeding min or max when typing or pasting values

Open

#2,071 创建于 2018年2月2日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
Package: coreType: enhancementhelp wanted

描述

Current NumericInput implementation caps properly at bounds when using the mouse, but when one types or pastes a value, the input should prevent typing a value exceeding the limits, it currently does not and users can type garbage.

One way to prevent this is, until a solution appears, is to check again the bounds in the onValueChange event, but is redundant.

贡献者指南

技术栈
typescriptreacthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React state handlingNumericInput component APIinput event handlingbounds validation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the NumericInput component's onValueChange event handler in the Blueprint source code (likely in packages/core/src/components/forms/numericInput*.ts). The existing implementation enforces min/max bounds for mouse interactions; replicate that logic for typed/pasted input. Ensure validation occurs before updating state, preventing values outside the range. Check for any existing onBlur validation that might duplicate this effort.