palantir/blueprint

[DateInput] DateInput re-opens after changing time

Open

#1,831 创建于 2017年11月21日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: bughelp wanted

描述

Bug report

  • Package version(s): 1.33.0
  • Browser and OS versions: Chrome 62.0.3202.94, Firefox 57.0, Firefox 56.0 on Windows 10

Steps to reproduce

Reproducible on the documentation page for DateInput http://blueprintjs.com/docs/#datetime/dateinput

See a video of the bug here: https://youtu.be/3Z7MrvRJ0xU

  1. Set DateInput precision to Minute, so the TimePicker is shown
  2. Open the DateInput
  3. Change the time in the TimePicker, you need to actually set a new value, it seems
  4. Close the DateInput by clicking outside

Actual behavior

The DateInput will close and then immediately open again

Expected behavior

The DateInput will close

贡献者指南

技术栈
reacttypescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the DateInput component's behavior when the TimePicker changes. Look at the file `packages/datetime/src/dateInput.tsx` for the `handleTimeChange` and `handleClose` methods. The bug suggests a race condition or event propagation issue causing the DateInput to reopen after clicking outside. Check if there's a focus related issue in the TimePicker or DateInput's popover. Also review the comments on the issue for additional context.