Hashing functions from `node:crypto` don't support the same inputs as Node.js · oven-sh/bun#18019

(1 评论) (0 反应) (0 负责人)Rust (90,348 star) (4,486 fork)batch import

buggood first issuenode:crypto

描述

What version of Bun is running?

1.2.4+fd9a5ea66

What platform is your computer?

Linux 6.1.91-060191-generic x86_64 x86_64, the issues isn't platform specific

What steps can reproduce the bug?

The following code...

import crypto from "node:crypto"

console.log(crypto.hash("shake-128", "", "base64url"))

...runs successfully on node.js and logs...

> node x.js 
f5wrpOiPgn1hYEVQdgWFPg

However, Bun throws an error.

> bun x.js 
1 | import crypto from "node:crypto"
2 | 
3 | console.log(crypto.hash("shake-128", "", "base64url"))
                       ^
TypeError: Unsupported algorithm "shake-128"
 code: "ERR_INVALID_ARG_TYPE"

      at /workspace/x.js:3:20

Bun v1.2.4 (Linux x64)

Bun does support the actual algorithms. For example, using "shake128" (without the hyphen) does work. Bun does not support the same aliases as Node.js, creating interop issues.

What is the expected behavior?

Same as Node.js

What do you see instead?

ERR_INVALID_ARG_TYPE

Additional information

No response

贡献者指南

技术栈: javascript
领域: api
议题类型: bug
难度: 3
预计时间: 1-3 hours
活动状态: fresh
清晰度: clear
前置要求: 无
新手友好度: 80
研究方向: The issue is that Bun's crypto.hash does not support all algorithm name aliases that Node.js does, e.g., 'shake 128' vs 'shake128'. Look at the implementation of the crypto module in Bun, likely in src/js/node/crypto.js or a native file, to find where algorithm names are validated and mapped. Add missing aliases by referring to Node.js's supported algorithm names. The fix is localized and should involve adding the hyphenated variants to the list of supported algorithms.