EUJ LO.4Impact: MediumWork: Lowenhancementgood first issue
仓库指标
- 星标
- (5,292 个星标)
- PR 合并指标
- (PR 指标待抓取)
描述
Is your feature request related to a problem? Please describe.
We are currently migrating from E2E tests to Acceptance tests; however, some of the E2E tests are still not covered by Acceptance tests. We need to write acceptance tests covering these uncovered E2E tests and delete the corresponding E2E test.
The goal is to create a new acceptance test that covers the features currently handled by the existing E2E test.
Describe the solution (or solutions) you'd like
Write the new acceptance test and delete the existing E2E test.
Steps to follow:
- Create a new acceptance test file in the appropriate directory.
- Write the acceptance test based on the specifications found in the WIP Doc (Internal/External Users) linked below.
- Add the acceptance test to acceptance.json.
- Run the newly created test-suite locally and ensure it passes.
- Push the code to your repo-fork.
- Stress test the new test-suite to check for flakes. (In your Oppia repo fork, go to Actions > Stress Test Acceptance Test > Run Workflow > branch:
<YOUR_FEATURE_BRANCH_NAME>, runs:20, test-suite:<TEST_SUITE_NAME_USED_IN_ACCEPTANCE.JSON>). - Ensure that all jobs pass in the above workflow run.
- Remove the corresponding E2E test file.
- Open a PR.
Describe alternatives you've considered and rejected
No response
Additional context
No response
E2E Tests to be Removed
- publicationAndLibrary.js
Acceptance Tests to be Added / Updated
- [EDITED] 🟡 LO.4. Play through a lesson (WIP External Users)
- Add first step in the acceptance test.
- Make required changes in setup.
Documentation References
- WIP Doc (Internal Users)
- WIP Doc (External Users)
- Puppeteer Acceptance Tests Folder: [GitHub Link](https://github.com/oppia/oppia/tree/develop/core/tests/puppeteer-acceptance-tests)
- Acceptance Test Wiki: [GitHub Wiki](https://github.com/oppia/oppia/wiki/Acceptance-Tests)
[!IMPORTANT] If you want to claim this issue, strictly follow the instructions below:
- Read the guidance (if you haven't already):
https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue- As this issue is simple, no need to explain how you’ll fix it — just provide proof you can complete it.
- Run:
Recordings will be saved inVIDEO_RECORDING_IS_ENABLED=1 python -m scripts.run_acceptance_test --suite=<SUITE>../oppia_full_stack_test_video_recordings.
Link all recordings from the latest run.- Use the required message template (see below).
- For this issue, add the code changes in your message too.
Hi @jayam04 @FaithAbiola, I would like to take up this issue. I will update the following files: {List files here} Here is proof of changes: Acceptance test 1: <Replace with acceptance test name> {List all screen recordings} Acceptance test 2 (if applicable): {List all screen recordings} File Changes {Screenshot of file changes OR use `git diff`}If there is no response, feel free to ping again.