oppia/oppia

[Feature Request]: Remove E2E test topicAndStoryEditor.js

Open

#24,932 创建于 2026年2月16日

在 GitHub 查看
 (12 评论) (0 反应) (1 负责人)Python (5,292 star) (3,534 fork)batch import
IUJ TM.3Impact: HighWork: Mediumenhancementgood first issue

描述

Is your feature request related to a problem? Please describe.

We are currently migrating from E2E tests to Acceptance tests, however, some of the E2E tests are still not covered by Acceptance tests. So, we need to write acceptance tests covering uncovered E2E tests and delete the corresponding E2E test.

Acceptance test(s) for "TM.3. Create, delete and edit stories and chapters" (e.g. Save chapters with mobile-supported explorations, Edit and preview a chapter) need to be created or updated to cover the features currently covered by E2E test "topicAndStoryEditor".

Describe the solution (or solutions) you'd like

Write or update the acceptance test(s) for TM.3 (Create, delete and edit stories and chapters) to cover the scenarios in topicAndStoryEditor.js, and delete the existing E2E test (wipeout).

Steps to follow:

  1. Update the existing acceptance test for TM.3: core/tests/puppeteer-acceptance-tests/specs/topic-manager/create-delete-and-edit-the-stories-and-chapters.spec.ts (test-suite name in acceptance.json: topic-manager/create-delete-and-edit-the-stories-and-chapters).
  2. Write/add the new steps based on TM.3. Create, delete and edit stories and chapters from CUJ v3 Sheet (Internal).
  3. No new entry in acceptance.json is needed (the test-suite is already registered).
  4. Extend the spec to cover the missing scenarios from topicAndStoryEditor.js (e.g. same exploration for two chapters → warning, reorder chapters, prerequisite/acquired skill validation, delete prerequisite and acquired skill) as needed.
  5. Run newly created/updated test-suite locally and ensure it passes.
  6. Push the code to your repo-fork.
  7. Stress test the new test-suite to check for flakes. (In your Oppia repo fork, go to Actions > Stress Test Acceptance Test > Run Workflow > branch: <YOUR_FEATURE_BRANCH_NAME>, runs: <ATLEAST_20>, test-suite: <TEST_SUITE_NAME_USED_IN_ACCEPTANCE.JSON>.)
  8. Ensure that all jobs passes in the above workflow run.
  9. Remove E2E test, topicAndStoryEditor.js.
  10. Open a PR :)

Other References:

puppeteer-acceptance-tests is the base folder for acceptance tests. Acceptance tests: https://github.com/oppia/oppia/wiki/Acceptance-Tests

Describe alternatives you've considered and rejected

No response

Additional context

No response

贡献者指南

[Feature Request]: Remove E2E test topicAndStoryEditor.js · oppia/oppia#24932 | Good First Issue