openzfs/zfs

Ability to specify type to 'zfs destroy`

Open

#9,522 创建于 2019年10月28日

在 GitHub 查看
 (5 评论) (15 反应) (0 负责人)C (9,908 star) (1,703 fork)batch import
Type: Featuregood first issue

描述

System information

Type Version/Name
Distribution Name all
Distribution Version all
Linux Kernel all
Architecture all
ZFS Version all
SPL Version all

Describe the problem you're observing

There are no safeguards when destroying. Whatever is the argument of zfs destroy, it will get destroyed. Issuers of the destroy command are humans and humans can make mistakes: for example in shell scripts that generate destroy commands, typos etc.

A minimal protection mechanism could reject a destroy action if the type of the dataset to be destroyed does not match the dataset type specified in command line, similar to how zfs list -t works, so for example zfs destroy -t filesystem pool/volumename or zfs destroy -t snapshot pool/filesystem would fail.

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs

贡献者指南

技术栈
cshell
领域
cli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C programmingZFS dataset types
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the implementation of the destroy command in cmd/zfs/zfs main.c. Study how the t flag works in zfs list for type filtering. Determine where dataset type is retrieved in the destroy code path. Look at how the ZFS IOC DESTROY ioctl handles type information. Consider adding a new flag like t and validating the dataset type against the argument. Review any existing discussions in the issue comments for design considerations.