openzfs/zfs

ZFS command output uses wrong comma separator

Open

#16,987 创建于 2025年1月23日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)C (9,908 star) (1,703 fork)batch import
Type: Defectgood first issue

描述

Distribution Name | Ubuntu/Arch Linux Distribution Version | 22.04.5/Current Kernel Version | 5.15.0/6.6.72 Architecture | amd64 OpenZFS Version | 2.1.5/2.3.0

openzfs’ supposedly human readable output uses a full stop rather than a comma as the decimal separator even in locales that require the latter.

Besides being an aesthetic problem this makes sort useless: `$ zfs list -o used | sort -h USED 12K 536K 897K 239M 239M 5.38M 7.43M 10.3G 10.3G 3.07G 3.07G 42.2G 42.2G 62.8G 6.81G 6.82G

$ export LANG=C $ zfs list -o used | sort -h USED 12K 536K 897K 5.38M 7.43M 239M 239M 3.07G 3.07G 6.81G 6.82G 10.3G 10.3G 42.2G 42.2G 62.8G`

Problem doesn’t exist in illumos’ zfs.

贡献者指南

技术栈
c
领域
cliinternationalizationlocalization
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of CConcept of locale and decimal separators
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue is about zfs list using a period instead of locale appropriate decimal separator. Start by searching for locale or decimal separator handling in the output formatting code, likely in libzfs. Look at functions that format numbers for 'used' column, possibly using strtod or custom formatting. Add call to localeconv() to get decimal point and use it in format strings. Test with German locale to verify comma appears. No linked PR yet; the issue has an assignee.