opensearch-project/opensearch-benchmark-workloads

[BUG] Unused search operations in the nyc_taxis workload

开放

#67 创建于 2023年3月21日

 (1 条评论) (0 个反应) (1 位负责人)Python (137 个派生)auto 404
Low Prioritybuggood first issue

仓库指标

星标
 (33 个星标)
PR 合并指标
 (平均合并 5天 19小时) (30 天内合并 2 个 PR)

描述

What is the bug?

The 'nyc_taxis' workload contains the following search operations (defined here).

  1. default
  2. range
  3. distance_amount_agg
  4. autohisto_agg
  5. date_histogram_agg
  6. date_histogram_calendar_interval
  7. date_histogram_calendar_interval_with_tz
  8. date_histogram_fixed_interval
  9. date_histogram_fixed_interval_with_tz
  10. date_histogram_fixed_interval_with_metrics
  11. auto_date_histogram
  12. auto_date_histogram_with_tz
  13. auto_date_histogram_with_metrics

Out of these, only 1–5 are being used in a test-procedure (append-no-conflicts) while they remaining are not mapped to any test-procedure (defined here). This reduces our coverage for 'aggregation' queries.

It appears that the 'date-histogram' test-procedure that executed these unmapped operations was incorrectly removed in https://github.com/opensearch-project/opensearch-benchmark-workloads/commit/cba4e45dda37ac03abbd3c9dd4532475dac355e9, thinking it was part of X-pack code, which it wasn't.

What is the expected behavior?

The missing test-procedure should be added back. I have confirmed that these operations execute successfully on open-source OpenSearch.

What is your host/environment?

Ubuntu 22.04.2 LTS (GNU/Linux 5.15.0-1031-aws x86_64) opensearch-benchmark 0.2.0

贡献者指南