openfoodfacts/openfoodfacts-server

Folksonomy Engine loads CSS and a font from CDNs

Open

#9,012 创建于 2023年9月17日

在 GitHub 查看
 (6 评论) (3 反应) (0 负责人)Perl (477 star) (236 fork)batch import
:star: :bug: top bug:star: top issueCSSJavaScriptgood first issue🎯 P1🏷️ Folksonomy Project

描述

https://github.com/openfoodfacts/openfoodfacts-server/blob/a0e358e7a79f55ed457d5676067e121ff7097416/html/js/folksonomy.js#L63-L65

image

For ProductOpener itself, we usually try to reduce the dependency on 3rd party CDNs. folksonomy.js does the opposite by loading three files from three different CDNs.

  1. jQuery UI is already bundled with ProductOpener
  2. FontAwesome could be revisited, because ProductOpener now mostly seems to use Material Icons since the redesign
  3. Bundle jqGrid, or replace it (if there's feature parity) with other grid already bundled?

Code pointers

You can find some code pointers here. If some are missing, feel free to add them yourself in this file, or to ask them.

Part of

  • #7525

贡献者指南

技术栈
javascriptcss
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptunderstanding of CDN dependencies
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the files mentioned: templates/web/common/includes/folksonomy script.tt.html and html/js/folksonomy.js. Identify which CSS and font files are loaded from CDNs (likely jQuery UI, FontAwesome, jqGrid). Check the existing bundles in ProductOpener (e.g., jQuery UI is already bundled) and propose replacing CDN links with local references or alternatives. No pull requests or maintainer responses are present yet.