openfaas/openfaas-cloud

Suggestion: Clean-up orphaned secrets

Open

#255 创建于 2018年9月30日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Go (222 fork)auto 404
area/securitydesign/reviewhelp wantedpriority/highskill/intermediate

仓库指标

Star
 (770 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Expected Behaviour

When a secret is no longer bound to a function it should be reclaimed

Current Behaviour

These are removed manually

Possible Solution

Initially perhaps we could reclaim SealedSecrets on a periodic basis via cron / kubectl? this would cause the SealedSecrets controller to remove the Secret from Kubernetes.

We may also want to look into updating import-secrets so that it can remove as well as create SealedSecrets. Alternatively garbage-collect may need extending.

Please make some suggestions on pros/cons before working on this.

Also in scope is documenting the behaviour when complete in the docs/README.md file.

Steps to Reproduce (for bugs)

  1. Add a SealedSecret to your repo and function
  2. Deploy function and check it can access the secret
  3. Remove the secret from the repo (this does another push and the new version of the function will have no secrets attached, but the secret will still exist)

贡献者指南