open-telemetry/opentelemetry-php

service.version being set by Composer

已关闭

#1,320 创建于 2024年6月5日

 (3 条评论) (0 个反应) (0 位负责人)PHP (224 个派生)auto 404
bite sizedbughelp wanted

仓库指标

星标
 (894 个星标)
PR 合并指标
 (平均合并 5天 5小时) (30 天内合并 5 个 PR)

描述

@julianocosta89 opened a slack thread to discuss seeing the service.version resource attribute set, even though it was not being set by default.

After getting more clarity in the #otel-community-demo channel, @puckpuck mentioned the following:

I did some sleuthing. This is set in the Composer detector here: https://github.com/open-telemetry/opentelemetry-php/blob/main/src/SDK/Resource/Detectors/Composer.php#L23-L26
Within Composer if you don't have a version set you will get the Default version which matches what we see in the otel-demo https://github.com/composer/composer/blob/main/src/Composer/Package/RootPackage.php#L22
I wonder if we should be using the version from Composer if it is set to the Default (unset)?


We should probably determine how we want to handle this service.version in the future. Other SIGs do not set this by default, so perhaps maybe we shouldn't have composer set this value if possible.

贡献者指南