open-duelyst/duelyst

Game gifs - hero & map - does not render if the screen size is too small

Open

#290 创建于 2023年5月31日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (3,443 star) (526 fork)batch import
bugfrontendhelp wanted

描述

Summary

When the screen is too small, the assets don't load in the game, this includes the map and the characters such as heros & character gifs, making it not really possible to play.

Impacted services

  • The frontend app

Steps to reproduce

  1. Start a local server and open the game in the chrome browser.
  2. Open the chrome inspector and use the device toolbar to use Pixel 4 dimensions, 353 * 745 in the webapp.
  3. Restart the game
  4. Load a practice match

The map does not render in the game & the heros don't load. (This also happens if you open the webapp on a phone like Pixel 6). Expected behaviour is that the characters load.

Environment information

  • Operating system: E.g. Linux
  • Browser: E.g. Chrome or Safari (could repro in both)

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the asset loading mechanism in the frontend, particularly how map and hero gifs are rendered. Check for any responsive CSS or JavaScript that conditionally loads assets based on screen size. Look at files like src/components/GameBoard.js or similar CSS media queries. The issue may be caused by missing breakpoints or incorrect handling of small screen dimensions.